Shouldn't we add a test for current like if current > max then current = max because if I write {{TitleBar/Norn|171017}} the progression bar is overfilled?
Slayer of All (10)
(same problem with every bars, see my page)
Corsaire 11:51, 16 November 2008 (UTC)
- Is fixed on this one, thanks for noticing. —Dr Ishmael
15:17, 16 November 2008 (UTC) - I put that fix in all of them except Guardian, Protector, Skill Hunter, and Vanquisher. Since they have a different max for each continent, it would've required a lot more code than the rest. But since the in-game values for them can never go above the max, the only time someone would force an overflow is if they put a junk number in to begin with, so I don't think it'll be a problem. —Dr Ishmael 15:34, 16 November 2008 (UTC)
- OK.. I had to go and didn't understood at once the {{{1|0}}} part, so I didn't did it myself.. :$
- Note that I took the liberty to modify also the skill hunter template: for Elona, players can have 141 on 140 skill captured, and as 140 is the highest number enven throu the 3 campaings, we can do the test here..
- But.. in the code, what about this "improvement" who can work in every case:
- |current = {{#ifexpr:{{{2|0}}}>{{#switch:{{{1}}}|Tyrian=90|Canthan=120|Elonian=140|1}}|{{#switch:{{{1}}}|Tyrian=90|Canthan=120|Elonian=140|1}}|{{{2|0}}}}}
- .. as you do in the "progression-text" variable?
- (should we continue on skillhunter talk?) Corsaire 08:56, 17 November 2008 (UTC)